Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a limit of 8MiB to secio messages size #236

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add a limit of 8MiB to secio messages size #236

merged 1 commit into from
Dec 17, 2019

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Dec 9, 2019

This is apparently already the case in practice, but we should add it to the specs.

jacobheun
jacobheun approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference, JS secio currently limits to 4MiB.
8MiB is based on the go implementations limit.

@tomaka
Copy link
Member Author

tomaka commented Dec 9, 2019

They should be unified to either value. If the Go code sends a 6MiB frame to the JS, it will get refused, and that's an incompatibility.

@jacobheun
Copy link
Contributor

They should be unified to either value. If the Go code sends a 6MiB frame to the JS, it will get refused, and that's an incompatibility.

Agreed. If no one has issues with this, JS can easily make the switch for the upcoming refactor release.

@tomaka tomaka mentioned this pull request Dec 9, 2019
Merged
@Stebalien Stebalien merged commit 7467aec into master Dec 17, 2019
@jacobheun jacobheun mentioned this pull request Dec 18, 2019
Closed
@tomaka tomaka deleted the tomaka-patch-1 branch December 21, 2019 16:08
@jacobheun jacobheun mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@Stebalien Stebalien Stebalien approved these changes

@raulk raulk Awaiting requested review from raulk

@richardschneider richardschneider Awaiting requested review from richardschneider

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaka @jacobheun @Stebalien